-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual ports between RefPorts and VarPorts #195
Merged
Merged
+858
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
…t (wip) Signed-off-by: Mathis Richter <[email protected]>
� Conflicts: � src/lava/magma/compiler/compiler.py � src/lava/magma/core/model/py/ports.py � tests/lava/magma/core/model/py/test_ports.py
Signed-off-by: Mathis Richter <[email protected]>
…hierarchical Processes Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
� Conflicts: � src/lava/magma/compiler/compiler.py
Signed-off-by: Mathis Richter <[email protected]>
…ical Processes. Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
…hical Processes. Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
PhilippPlank
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
awintel
approved these changes
Mar 1, 2022
Signed-off-by: Mathis Richter <[email protected]>
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* permute initial implementation Signed-off-by: bamsumit <[email protected]> * Tests for permute ports * Process property of virtual ports no longer returns None Signed-off-by: Mathis Richter <[email protected]> * Added initial run-unittest for flatten() from issue lava-nc#163 Signed-off-by: Mathis Richter <[email protected]> * User-level API for TransposePort with unit tests Signed-off-by: Mathis Richter <[email protected]> * Fixed typo Signed-off-by: Mathis Richter <[email protected]> * Unit tests for flatten() and concat_with() Signed-off-by: Mathis Richter <[email protected]> * Unit tests for virtual ports in Processes that are executed (wip) Signed-off-by: Mathis Richter <[email protected]> * Preliminary implementation of virtual ports between OutPort and InPort (wip) Signed-off-by: Mathis Richter <[email protected]> * Fixing unit tests after merge Signed-off-by: Mathis Richter <[email protected]> * Added support for virtual ports between an OutPort and InPort of two hierarchical Processes Signed-off-by: Mathis Richter <[email protected]> * Clean up, exceptions, and generic unit tests for virtual port topologies Signed-off-by: Mathis Richter <[email protected]> * Fixed linter issues Signed-off-by: Mathis Richter <[email protected]> * Raising an exception when executing ConcatPort Signed-off-by: Mathis Richter <[email protected]> * Unit tests for virtual ports between OutPorts and InPorts in hierarchical Processes. Signed-off-by: Mathis Richter <[email protected]> * RefPort writing to an explicit VarPort via a virtual port. Signed-off-by: Mathis Richter <[email protected]> * RefPort reading from an explicit VarPort via a virtual port. Signed-off-by: Mathis Richter <[email protected]> * Fixed linter error Signed-off-by: Mathis Richter <[email protected]> * Unit tests for virtual ports between RefPorts and VarPorts in hierarchical Processes. Signed-off-by: Mathis Richter <[email protected]> * Fixed a docstring Signed-off-by: Mathis Richter <[email protected]> * Added docstrings to methods get_transform_func_fwd/bwd. Signed-off-by: Mathis Richter <[email protected]> Co-authored-by: bamsumit <[email protected]> Co-authored-by: Marcus G K Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #194
Objective of pull request: Provide support for virtual ports between RefPorts and VarPorts
Pull request checklist
Your PR fulfills the following requirements:
pyb
) passes locallypyb -E unit
) or (python -m unittest
) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information